http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1383
jeff.morriss@xxxxxxxxxxx changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Comment #9 from jeff.morriss@xxxxxxxxxxx 2007-03-10 08:44 GMT -------
Commited in rev 21016 with some changes, including:
Since the message types are in a value_string, there's no need to pull out the
pointer to the string and do 'proto_tree_add_uint_format_value()': instead put
the value string in the hf entry for message type and just cursor_add it.
Return FALSE at the end of 'check_epmd()': that's the point of the routine
after all. :-)
There's no need to first check if tvb_bytes_exist(tvb,0,1) and then
tvb_bytes_exist(tvb,0,3); just leave the latter in.
Only free the cursor if it was allocated.
Merged dissect_epmd2() into dissect_epmd() (it's not like there's too much code
there anyway).
If you could add a section on the Wiki about this protocol (and put this sample
capture there), that would be great. Also, do you want to put anything in the
INFO column about this protocol? The field names/descriptions are quite short,
too, but I suppose they may make sense to someone who knows the protocol.
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
