Wireshark-bugs: [Wireshark-bugs] [Bug 1383] support for the epmd protocol
Date: Fri, 9 Mar 2007 15:10:16 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1383





------- Comment #5 from jeff.morriss@xxxxxxxxxxx  2007-03-09 15:10 GMT -------
Why not use a value_string here:

static char*
message_type(guint8 type) {
    switch (type) {
        case EPMD_ALIVE:
            return "Alive";
        case EPMD_PORT_PLEASE:
            return "Port Please";


Also, could you attach a sample capture either here or to the Wiki?

One more thing that would be a Good Thing would be if this dissector were a
"new style" dissector (that is, it could return the number of bytes it
successfully dissected as EPMD or 0 if it thinks the packet is not EPMD).  Its
port number is registered, but you never know if someone's going to set up a
web server on that port (and then capture that web traffic with Wireshark)...


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.