Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 1387] New: lemon Makefile breaks BSD make compatiblity

[bugzilla-daemon@xxxxxxxxxxxxx]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1387

           Summary: lemon Makefile breaks BSD make compatiblity
           Product: Wireshark
           Version: 0.99.5
          Platform: Other
        OS/Version: OpenBSD
            Status: NEW
          Severity: Major
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: nikns@xxxxxxxxx


Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
If not using GNU make(when using BSD make) I get following error:
===>  Building for wireshark-0.99.5
[..]
make  all-recursive
Making all in tools
Making all in lemon
Using $< in a non-suffix rule context is a GNUmake idiom (line 605 of Makefile)
*** Error code 1




The fix seems to be:
--- tools/lemon/Makefile.in.orig        Tue Feb 20 17:28:15 2007
+++ tools/lemon/Makefile.in     Tue Feb 20 17:28:21 2007
@@ -602,7 +602,7 @@ uninstall-am: uninstall-info-am


 lemon$(EXEEXT): lemon.c
-       $(CC_FOR_BUILD) -D_U_="" $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD) -o $@
$<
+       $(CC_FOR_BUILD) -D_U_="" $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD) -o $@
$?
 # Tell versions [3.59,3.63) of GNU make to not export all variables.
 # Otherwise a system limit (for SysV at least) may be exceeded.
 .NOEXPORT:


This is the only place in Makefiles which breaks BSD make compatiblity.
Would be good to fix this so that there wouldn't be gmake dependency.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.