> Guy Scharf wrote:
> >
> > > With my change, however, it doesn't do that.
> >
> > That describes the situation. The "narrow" columns do seem to fit the
> > column titles well. Then it pops back to a width that holds all. Then
> > it shrinks to title-width columns again.
> >
> > I still don't like the idea of resizing columns each time new records
> > are read with -S.
>
> I agree and there is still resizing with the current CVS tree.
I never said it wasn't in the current CVS tree.
The benefits of auto-resizing are:
1) the code that sets the sizes doesn't have to know the stuff
that all the different packet decoders put into the columns -
but it may be possible to achieve this by centralizing some
of the stuff that puts stuff into the columns, and possibly
having the decoders explicitly specify how big they think the
columns should be.
2) the columns are adjusted so that none of them are too small
(cutting off some data) or too big (wasting space) - but the
source and destination address columns, if they contain
names, may have stuff at the end of the name that is
redundant (and, if not, the user could manually resize the
column), and it may be that, for everything except "Info"
(which should, by default, get all the space that's left), a
column that's big enough won't be too big (if no row has
something in that column that's the maximum size).
3) if you change the time format to one that's wider, you don't
then have to manually resize the column to a size that
Ethereal already knows is appropriate.
I'm not willing to give up 3); I found having to manually resize the
"Time" column if I used "Display/Options" to select "Time of day"
unacceptable.
However, most of what 1) and 2) give you can be achieved in other ways,
and the resizing of the columns when the time format is changed is done
with different code (which can choose different fixed sizes, rather than
auto-sizing), so I'd be willing to have Ethereal not auto-size the
columns based on the data in the columns, as long as it does resize the
"Time" column if the time display format is changed.
