Hi Samuel,
Thank you for looking into this. I've glanced through your code (I'm no
expert on this stuff) and can only make the following suggestions:
1. Please supply patches against the development tree. 'svn diff' or
'diff -ur' provide the most usable patch files. This way you can leave out
the SAMUEL marks and can we look at just the changes.
2. Please don't leave out the dot in the version, use TLSV1DOT1_... as
symbol
3. Please use the defines. You define TLSV1DOT1_VERSION, so please use
that in the code, in comparisons like ->version == TLSV1DOT1_VERSION).
Thanx,
Jaap
On Thu, 18 May 2006, authesserre samuel wrote:
> Hi,
>
> This little mail to give you a little adaptation of SSL/TLS dissector who
> allow TLS 1.1 dissection. (all differences are marked by /* SAMUEL */ that
> allow you to compare easily the 2 versions)
> I have realized this with mod_gnutls for apache (the only free
> implementation I've found of TLS 1.1) and opera (who is the only web
> navigator that use TLS 1.1).
>
> I have founded an error in the original plugin that I don't success to
> correct :
> the TCP desegmentation doesn't work correctly, I give you capture of TLS 1.0and
> 1.1 but the result is the same. I have compared http dissector with ssl
> dissector and the source are similar (the desegmentation part... ;) ) so I
> don't understand where the problem come from (the pinfo->can_desegment = 0
> in all time so this can't work correctly, but normally it should be equal to
> 1 ??).
>
> Use of mod_gnutls allow me to see an other bug : it's due to segmentation of
> application data in SSL/TLS : the gnutls module put header and data of HTTP
> traffic in differents TCP packets so the data is bad analysed and the plugin
> show "data (n bytes)" (in the log the capture and decryption is good) (see
> packet 24 and 25 of the TLS 1.1 capture for exemple)
> The problem is that we can't see the data of the packet whereas the data are
> correctly decrypted....
>
> I have already send a mail to the creator of the decryption part of the
> plugin but I think that the error came with the first version of the plugin
> so I ask you help...
>
> best regards
>
> --
> ++++++++++++++++++++++++++
> + Authesserre Samuel +
> + 12 rue de la d?fense passive+
> + 14000 CAEN +
> + FRANCE +
> + 06-27-28-13-32 +
> + sauthess@xxxxxxxxx +
> ++++++++++++++++++++++++++
>
_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev
