ronnie sahlberg wrote:
We could also extend it with having a flat database file that is used
by proto_tree_add_...() that does the same thing. So that we dont
have to add a PROTO_ITEM_SET_URL() a thousand times for items that are
added from multiple codepaths.
So that
smb2.impersonation_level http://wiki.ethereal.com/SMB2/ImpersonationLevel
could be used to tell ethereal to make ALL items created for this
field to always be linked to this url without a need to specify it
explicitely in the code.
(some fields are referenced many times from the code)
So, in effect, add it to the hf_ information might be a better idea in
most cases.
This could also replace the "link to protocol page" code that is
another explicitely coded special case of external links.
ACK
It would be nice if there would be an indication in the dissect pane
to show that the particular item is linked to an external resource.
A link icon to the left of the field name in the dissect pane?
When I remember correct, an icon isn't possible with the tree we are
using (or not properly displayable, can't remember).
We might need to find a "visual expression" in text form for the URL.
However, I didn't thought about how this could look like.
If
there is only one such external link then clicking on it would open a
browser and go straight to that link. If there are multiple links
associated to the field then it would send you to the "primary" link
where which one is primary is selected by some mechanism.
Right clicking on the link icon would bring up a popup menu that only
contains the list of external links.
Sounds a bit confusing at first sight, but don't have a better idea either.
The normal popup menu would be as today and not contain any links (no
additional cluttering to the existing popup)
ACK
Regards, ULFL
