Ethereal-dev: Re: [Ethereal-dev] packet-tcp.h should include emem.h

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Thomas Boehne <TBoehne@xxxxxxxx>
Date: Tue, 11 Apr 2006 11:26:06 +0200
On Tuesday 11 April 2006 10:35, Jaap Keuter wrote:
> On Tue, 11 Apr 2006, Thomas Boehne wrote:
> > My dissector includes packet-tcp.h, which uses se_tree_t from emem.h
> > without including it. Could someone please add an
> >
> > #include <epan/emem.h>
> >
> > to packet-tcp.h? Or is there a special reason for not including it?
>
> There doesn't seem to be a coding rule within the Ethereal code base that
> states that a header file itself must include the header files it depends
> on. If it is we have a whole lot of work to do...

OK, I'll just fix it in my dissector then. However, I thought there
were other people that might run into the same problem and fixing it
in packet-tcp.h would save them some trouble and time.

Regards,
Thomas

-- 
Jäger Computergesteuerte Messtechnik GmbH
Thomas Böhne
Rheinstraße 2-4
64653 Lorsch
Germany
Phone: +49-6251-9632-0