Ethereal-dev: Re: [Ethereal-dev] Update to the NCP dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Fri, 31 Mar 2006 16:32:48 +0200 (CEST)
On Fri, 31 Mar 2006, Joerg Mayer wrote:

> On Fri, Mar 31, 2006 at 08:24:53AM +0200, Greg Morris wrote:
> > Fixes bug 830
> > Adds a few more expert info details.
> >
> > +static const value_string ncp_rights_vals[] = {
> > +  { 0x00, "No Rights"},
> > +  { 0x01, "Read"},
> ...
> > +  { 0x55, "Read, Deny Read, Compatibility, File Write Through"},
>
> Is there a reason why you don't decode this as individual bits?

Yes, please change this to decoding of the bitmaps.

Thanx,
Jaap