Ethereal-dev: Re: [Ethereal-dev] Armagetronad dissector update

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Mon, 27 Mar 2006 16:43:23 +0200 (CEST)
Hi,

+               guint16 *ptr, *end = (guint16*) &data[data_len];
+               for (ptr = (guint16*) data; ptr != end; ptr++) {

This will never end when data_len is odd.

Thanx,
Jaap

On Mon, 27 Mar 2006, Guillaume Chazarain wrote:

> Hi,
>
> Here is a bugfix for the dissector (proto_tree_add_string() expects a
> null terminated string),
> and an update to handle the new message types. I don't intend to send an
> update for every
> new message added, just wanted to base on a released version, not a CVS
> snapshot.
>
> Thanks.
>
> --
> Guillaume
>
>