Ethereal-dev: [Ethereal-dev] Trivial packet-sip.c [patch]

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Martin Mathieson <martin.mathieson@xxxxxxxxxxxx>
Date: Fri, 24 Mar 2006 14:11:17 +0000
Hi,

This patch adds a hidden 'sip.auth' field, that will be present whenever one of the authenticiation/authorization headers is present.

I believe this is one place where hidden fields are justified:
- it is a substring of several sip.auth.* fields, so its reassuring to see the field turn green as you're typing in one of the visible fields - it lets you quickly find all of the frames with any of these fields (there are 4 different SIP headers that can contain the auth fields)

Regards,
Martin


Index: epan/dissectors/packet-sip.c
===================================================================
--- epan/dissectors/packet-sip.c	(revision 17719)
+++ epan/dissectors/packet-sip.c	(working copy)
@@ -88,6 +88,7 @@
 static gint hf_sip_resend			= -1;
 static gint hf_sip_original_frame	= -1;
 
+static gint hf_sip_auth                  = -1;
 static gint hf_sip_auth_scheme           = -1;
 static gint hf_sip_auth_digest_response  = -1;
 static gint hf_sip_auth_nc               = -1;
@@ -1800,6 +1801,9 @@
 							                   tvb_format_text(tvb, offset, linelen));
 							sip_element_tree = proto_item_add_subtree( sip_element_item,
 							                   ett_sip_element);
+							proto_tree_add_item_hidden(hdr_tree, hf_sip_auth, tvb,
+							                           offset, next_offset-offset,
+							                           FALSE);
 						}
 
 						/* Parse each individual parameter in the line */
@@ -2875,6 +2879,11 @@
 			FT_FRAMENUM, BASE_NONE, NULL, 0x0,
 		    	"Original transmission of frame", HFILL}
 		},
+		{ &hf_sip_auth,
+			{ "Authentication",  "sip.auth",
+			FT_STRING, BASE_NONE, NULL, 0x0,
+		    	"SIP Authentication", HFILL}
+		},
 		{ &hf_sip_auth_scheme,
 			{ "Authentication Scheme",  "sip.auth.scheme",
 			FT_STRING, BASE_NONE, NULL, 0x0,