Ethereal-dev: SV: [Ethereal-dev] Patch for Bug #817

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Anders Broman" <a.broman@xxxxxxxxx>
Date: Thu, 23 Mar 2006 07:09:15 +0100
Hi,
I get the following warning when applying the patch:
packet-jxta.c
packet-jxta.c(554) : warning C4133: 'initializing' : incompatible types -
from '
struct conversation *' to 'struct jxta_stream_conversation_data *'

Brg
Anders

-----Ursprungligt meddelande-----
Från: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx] För Mike Duigou
Skickat: den 23 mars 2006 00:22
Till: Ethereal development
Ämne: [Ethereal-dev] Patch for Bug #817

I have improved the heuristics and the display tree building code in
dissect_jxta_udp() and dissect_jxta_stream() to avoid this problem.

Enclosed is a patch which corrects the problem.

There remains one point of confusion for me. Heuristic dissectors are 
supposed to return TRUE or FALSE. Assuming that the underlying 
dissection routine is a new style dissector returning "int" it is 
obvious that :
	new dissector result > 0 --> heuristic returns TRUE
	new dissector result == 0 --> heuristic returns FALSE
but what about :
	new dissector result < 0 --> heuristic returns ?????

If I suspect that a packet may contain JXTA data but need more data to 
make a determination what should my heuristic dissector return?

Mike