Ethereal-dev: Re: [Ethereal-dev] LNK2001 error with ncp echo file

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Sun, 19 Mar 2006 14:51:13 -0800
CHarris@xxxxxxxxxxxxxxxxxxxx wrote:

Yea, I have the packet-ncp-int.h file in my \ethereal\epan\dissectors
directory.
...which declares ncp_echo_file, but doesn't define it. ("extern" declares, but doesn't define, a C variable.)
I don't know why the other values, such as ncp_echo_err, don't show this problem. (I also don't know why that didn't show up in the buildbot buils; perhaps different versions of MSVC++ use different models, such as def/ref vs. common.)
Unless those are used outside packet-ncp.c, they should probably just be made static to packet-ncp.c, and not declared in packet-ncp-int.h.