Ethereal-dev: Re: [Ethereal-dev] Re: rev 17527: /trunk/plugins/profinet/: packet-pn-dcp.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Fri, 10 Mar 2006 17:00:04 +0100
> Use this updated patch instead.
> 

You make things worse than they are. 

Don't manipulate data coming from a packet! If the block_length in the packet is invalid, use it anyway.

Stopping the dissection of a packet because there are not enough data is a bad idea. Showing Malformed Packet is the way to go here.

BTW: You shouldn't check in fixes if you can't fuzz-testing it!

I'll check in some fixes later today...

Regards, ULFL
______________________________________________________________
Verschicken Sie romantische, coole und witzige Bilder per SMS!
Jetzt bei WEB.DE FreeMail: http://f.web.de/?mc=021193