Ethereal-dev: [Ethereal-dev] Re: rev 17527: /trunk/plugins/profinet/: packet-pn-dcp.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "ronnie sahlberg" <ronniesahlberg@xxxxxxxxx>
Date: Thu, 9 Mar 2006 23:33:59 +0000
I would say  just throw an exception  there.


I am not familiar at all with that protocol    and usually dont even
build with plugins.



On 3/9/06, Gerald Combs <gerald@xxxxxxxxxxxx> wrote:
> sahlberg@xxxxxxxxxxxx wrote:
> > User: sahlberg
> > Date: 2006/03/08 04:59 AM
> >
> > Log:
> >  fix coverity bug 122
> >
> > Directory: /trunk/plugins/profinet/
> >   Changes    Path               Action
> >   +6 -4      packet-pn-dcp.c    Modified
>
> There are a few places in the PN-DCP dissector that block_length might
> be used unititialized.  Is a zero block_length value ever valid in these
> cases?  If not, is it OK to throw an exception if it's zero/uninitialized?
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>