Wireshark · Ethereal-dev: RE: [Ethereal-dev] Re: [Ethereal-cvs] rev 17502: /trunk/tools/lemon/:lemon.c

["Anders Broman (AL/EAB)" <anders.broman@xxxxxxxxxxxx>]

Hi,
Well the link goes to the intended bugfix copied from that location:

--- lemon.c	2005/11/06 04:06:59	1.35
+++ lemon.c	2006/03/06 20:55:46	1.36
@@ -1747,6 +1747,7 @@
   int j;
   int errcnt = 0;
   cp = strchr(argv[i],'=');
+  assert( cp!=0 );
   *cp = 0;
   for(j=0; op[j].label; j++){
     if( strcmp(argv[i],op[j].label)==0 ) break;

 That's line 1541 in "our" code, sorry about that.
Brg
Anders

-----Original Message-----
From: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx] On Behalf Of Joerg Mayer
Sent: den 8 mars 2006 17:10
To: ethereal-dev@xxxxxxxxxxxx
Subject: [Ethereal-dev] Re: [Ethereal-cvs] rev 17502:
/trunk/tools/lemon/:lemon.c

On Tue, Mar 07, 2006 at 06:18:05PM +0000, etxrab@xxxxxxxxxxxx wrote:
> Log:
>  Fix a bug reported by covierty and solved by 
> http://www.sqlite.org/cvstrac/rlog?f=sqlite/tool/lemon.c
>  Rearrange the code a bit to make it easier to make a diff with the
sqlite version of lemon.

Can you please send a diff just for the bug? Hiding a bugfix inside a
code rearrangement makes it harder to spot.

Thanks
      Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev