Ethereal-dev: Re: [Ethereal-dev] emem.c patch to compile (and cleanly) with EP_DEBUG_FREE and

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Jeff Morriss <jeff.morriss@xxxxxxxxxxx>
Date: Wed, 08 Mar 2006 10:27:09 +0800

Gerald Combs wrote:

Jeff Morriss wrote:

emem.c wouldn't compile with EP_DEBUG_FREE and SE_DEBUG_FREE defined.

The attached patch fixes that and cleans up some warnings that showed up
with those two were defined, too.  (In fact 95% of the patch is for
warnings.)


Checked in.  Would it be helpful if the emem debugging code could be
enabled at run time instead of compile time?
It depends if it's desirable to have people who aren't building their own (presumably from SVN) running Valgrind. There are obvious advantages to that though it also means someone could waste their time testing/debugging something that was fixed in SVN 4 weeks ago...
I went ahead and started a Wiki page (sorry, no original content here!) for the canary and guard pages stuff: 

http://wiki.ethereal.com/Development/Canary
The attached mini-patch points developers to that page if they're wondering why Ethereal is exiting after detecting a canary violation. :-)

Attachment: emem.c.patch.gz
Description: GNU Zip compressed data