Ulf,
will ethereal and tethereal now use dumpcap by default?
It doesn't seem to do so on my system:
root 3856 10.6 2.9 68188 30916 pts/5 S+ 13:33 0:02 ethereal
root 3859 5.1 1.9 35264 19984 pts/5 S+ 13:33 0:00 ethereal-capture -i eth0 -f
and tethereal doesn't even have a child process.
Dumpcap definitely got built and installed.
Another thing: Now that this gets production quality, should be stay
with the name or use something more fancy (like inca or incato;
intelligent capture tool).
One last thing (which comes way too late::-) isn't this tool
already too powerful? Maybe a stupid capturing tool without the ability
to write files would have been safest. Just cpaturing to stdout or
something similar and everything else still done in (t)ethereal.
Ciao
Joerg
PS: Attached an untested modification for setuid.
--
Joerg Mayer <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
Index: configure.in
===================================================================
--- configure.in (revision 17270)
+++ configure.in (working copy)
@@ -823,7 +823,11 @@
if test "x$enable_setuid_install" = "xno" ; then
AC_MSG_RESULT(no)
else
- AC_MSG_RESULT(yes)
+ if test "x$enable_dumpcap" = "xno" ; then
+ AC_MSG_ERROR(Setuid install works only with --enable-dumpcap, but dumpcap disabled)
+ else
+ AC_MSG_RESULT(yes)
+ fi
fi
AM_CONDITIONAL(SETUID_INSTALL, test x$enable_setuid_install = xyes)
Index: Makefile.am
===================================================================
--- Makefile.am (revision 17270)
+++ Makefile.am (working copy)
@@ -685,8 +685,7 @@
if SETUID_INSTALL
install-exec-hook:
- -chmod +s $(DESTDIR)$(bindir)/ethereal
- -chmod +s $(DESTDIR)$(bindir)/tethereal
+ -chmod +s $(DESTDIR)$(bindir)/dumpcap
else
install-exec-hook:
endif
