On 2/7/06, Ulf Lamping <ulf.lamping@xxxxxx> wrote:
> LEGO wrote:
> > Actually it's just adding a check for it in the autofoo stuff (and now
> > I know how to do it myself!) then take the code from gnu getopt and
> > add it to a file.c by itself that would get compiled only if
> > long_getopt doesn't exists in the target machine. Much like we do for
> > strptime.
> >
> > On windows I don't know if we already have it... It would take me just
> > one buildbot run to find out :)
> >
> Just because you know how to do it really don't mean that you should do
> it that way (unless there's a good reason to do so).
>
> First of all, adding a dependency to another lib for no real reason is a
> pretty bad idea IMO.
> Next, if you want to add long options to Ethereal, you'll complicate the
> current command line options as some of the options will use short
> syntax and other ones long.
>
> Please remember to provide long options *for all* Ethereal command line
> options and not only "your own"! As that's the common way to provide
> command line options if long options are available.
>
> And please also remember to change *all* appearances of the command line
> option documentation:
> -Help output of the program
> -User's Guide
> -manpage
> -...?
Don't worry I wont use long options i'll use -x key:value .
And yes I'll add it to the UG, manpage and help.
> > However I like this more... a little bit confusing to use the same -a
> > for capture stop triggers and the lua script but as we said we shoud
> > use kanji instead of our very limited latin alphabet for ethereal
> > command line options :).
> >
> Missunderstanding
>
> Of course, you shouldn't use -a for lua scripting settings. But you
> probably should use a new letter for this and the same mechanism as we
> use with the -a letter already, namely a key:value pair.
>
I noticed the stupididity of what I wrote not much after I sent the
e-mail, I'll try to have more sleep. I'll use another letter, -x as
in eXtension, luckily that one is free (anyway we just got 4 letters
left (3 considering x) so either we move to a richer alphabet or the
--long option migh become a necessity in the future).
Luis.
--
This information is top security. When you have read it, destroy yourself.
-- Marshall McLuhan
