Ethereal-dev: Re: [Ethereal-dev] AVA - QBSS Patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Fri, 13 Jan 2006 06:31:18 +0100
On Wed, Jan 11, 2006 at 09:35:42PM +0100, Thomas Sillaber wrote:
> here's the patch without hidden fields and unused vars.

Is there a reason why you did the decoding outside
dissect_vendor_ie_aironet? That way you a) have to read the type again
and b) add a magic type 14 that should have gone into aironet_ie_type_t.
It just makes things less readable :-(

 ciao
   Joerg

-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.