Ethereal-dev: Re: [Ethereal-dev] AVA - QBSS Patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Wed, 11 Jan 2006 14:06:26 +0100
On Wed, Jan 11, 2006 at 12:40:47AM +0100, Jaap Keuter wrote:
> A few notes on your patch:
> - Coding style is not anything like the original file.

The coding style is ok. This file is a mess as far as coding style is
concerned anyway.

>   Different, sometimes inconsistent indentations.

Looks ok to me, I fix the indentation to the style I like whenever I
touch some code in this file.

> - Where do you need the hidden fields for?

right. no new hidden fields please.

 ciao
   Joerg

-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.