Ethereal-dev: [Ethereal-dev] Patch to fix RADIUS password display

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Graeme Hewson <ghewson@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 23 Dec 2005 17:10:31 +0000
Decryption of the RADIUS User-Password attribute is currently broken; fixed by the attached patch.
Passwords are displayed padded with literal "\000" sequences. I suggest radius_decrypt_avp() should be modified to insert a null instead when the attribute type is string.
Can anyone explain what "encrypt=1", "encrypt=2" and "encrypt=3" mean in the RADIUS dictionary? As far as I can see, radius_dict.l takes "encrypt=1" to mean TRUE, and ignores the other values. 


Graeme Hewson

--- packet-radius.c.orig	2005-12-22 11:18:02.000000000 +0000
+++ packet-radius.c	2005-12-23 13:47:51.000000000 +0000
@@ -847,7 +847,7 @@
 		
 		proto_tree_add_item(radius_tree, hf_radius_authenticator, tvb, 4,AUTHENTICATOR_LENGTH,FALSE);
 	}
-	tvb_memcpy(tvb,authenticator,0,AUTHENTICATOR_LENGTH);
+	tvb_memcpy(tvb,authenticator,4,AUTHENTICATOR_LENGTH);
 
 	if (tree && avplength > 0) {
 		/* list the attribute value pairs */