Ethereal-dev: [Ethereal-dev] Re: Extra check in field array registration [PATCH]

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
Date: Fri, 2 Dec 2005 10:26:55 +0000
sounds reasonable

On 12/2/05, Guy Harris <gharris@xxxxxxxxx> wrote:
> Jaap Keuter wrote:
>
> > When I tried the help menu option Supported Protocols it bombed on me. :/
> > I was running Ethereal with some extra plugins on Win32. Debugging my way
> > out of it I found that some hf_register_info blurbs were NULL i.s.o. "".
> > There seems to be no check on this when registering the field array. The
> > attached patch to proto.c solves this. The other patch is for the
> > developer manual, to change an example using NULL blurbs.
>
> Should we just allow NULL for the blurb, as well as a null string, if
> the author doesn't want to bother writing one (or if the fields are
> generated at compile time or run time from a file)?
>
>  http://www.ethereal.com/lists/ethereal-dev/200511/msg00098.html
>
>  http://www.ethereal.com/lists/ethereal-dev/200511/msg00114.html
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>