Crap. Shame on me, that's true. I've applied Fedora patches on the SVN
branch ..
:)
I wonder what exactly this patch was fixing ...
Radek
On Fri, 2005-11-04 at 09:26 -0600, Gerald Combs wrote:
> Did you happen to have this patch applied?
>
> http://cvs.fedora.redhat.com/viewcvs/rpms/ethereal/FC-4/ethereal-0.10.0a-ia64-segfault.patch
>
>
> Radek Vokál wrote:
> > Strange, I've removed proto.c and did svn update and it's fine now.
> >
> > On Fri, 2005-11-04 at 13:41 +0100, Jaap Keuter wrote:
> >
> >>Well, this is what I have
> >>-----8<-----
> >>jaap@phoenix:~/src/ethereal/ethereal/epan$ svn update
> >>At revision 16389.
> >>jaap@phoenix:~/src/ethereal/ethereal/epan$ cat proto.c | head -n 5
> >>/* proto.c
> >> * Routines for protocol tree
> >> *
> >> * $Id: proto.c 16381 2005-11-02 20:50:54Z ulfl $
> >> *
> >>jaap@phoenix:~/src/ethereal/ethereal/epan$ cat proto.c | head -n 2495 |
> >>tail -n 25
> >> return hfinfo;
> >>}
> >>
> >>static field_info *
> >>new_field_info(proto_tree *tree, header_field_info *hfinfo, tvbuff_t *tvb,
> >> gint start, gint item_length)
> >>{
> >> field_info *fi;
> >>
> >> FIELD_INFO_NEW(fi);
> >>
> >> fi->hfinfo = hfinfo;
> >> fi->start = start;
> >> fi->start+=(tvb)?TVB_RAW_OFFSET(tvb):0;
> >> fi->length = item_length;
> >> fi->tree_type = -1;
> >> fi->flags = 0;
> >> if (!PTREE_DATA(tree)->visible)
> >> FI_SET_FLAG(fi, FI_HIDDEN);
> >> fvalue_init(&fi->value, fi->hfinfo->type);
> >> fi->rep = NULL;
> >>
> >> /* add the data source tvbuff */
> >> fi->ds_tvb=tvb?TVB_GET_DS_TVB(tvb):NULL;
> >>
> >>-----8<-----
> >>
> >>Don't you have a locally editted copy of this file?
> >>What does svn status epan/proto.c say?
> >>
> >>Thanx,
> >>Jaap
> >>
> >>
> >>On Fri, 4 Nov 2005, Radek [ISO-8859-1] Vokl wrote:
> >>
> >>
> >>>On Fri, 2005-11-04 at 12:41 +0100, Jaap Keuter wrote:
> >>>
> >>>>Hi Radek,
> >>>>
> >>>>What's in the $Id$ field in the top of the proto.c file?
> >>>>I can't find your quoted code anywhere!
> >>>>
> >>>>Thanx,
> >>>>Jaap
> >>>
> >>> * $Id: proto.c 16381 2005-11-02 20:50:54Z ulfl $
> >>>
> >>>
> >>>
> >>>>
> >>>>On Fri, 4 Nov 2005, Radek [ISO-8859-1] Vokl wrote:
> >>>>
> >>>>
> >>>>>On Thu, 2005-11-03 at 09:57 -0800, Guy Harris wrote:
> >>>>>
> >>>>>>Radek Vokál wrote:
> >>>>>>
> >>>>>>>ethereal-0.10.13-SVN-16387
> >>>>>>>
> >>>>>>>proto.c:2482: error: 'hfindex' undeclared (first use in this function)
> >>>>>>>proto.c:2482: error: (Each undeclared identifier is reported only once
> >>>>>>>proto.c:2482: error: for each function it appears in.)
> >>>>>>
> >>>>>>I just did an "svn update", and line 24802 of "epan/proto.c" in the
> >>>>>>version I have is:
> >>>>>>
> >>>>>> fi->hfinfo = hfinfo;
> >>>>>>
> >>>>>>What is it in your version?
> >>>>>>
> >>>>>
> >>>>>It fails on line 2482!
> >>>>>
> >>>>> fi->hfinfo = gpa_hfinfo.hfi[hfindex];
> >>>>>
> >>>>>This is today svn buildroot source - ethereal-0.10.13-SVN-16389
> >>>>>
> >>>>>
> >>>>>
> >>>>>--
> >>>>>Radek Vokál <rvokal@xxxxxxxxxx>
> >>>>>
> >>>>_______________________________________________
> >>>>Ethereal-dev mailing list
> >>>>Ethereal-dev@xxxxxxxxxxxx
> >>>>http://www.ethereal.com/mailman/listinfo/ethereal-dev
> >>>
> >>>--
> >>>Radek Vokál <rvokal@xxxxxxxxxx>
> >>>
> >>_______________________________________________
> >>Ethereal-dev mailing list
> >>Ethereal-dev@xxxxxxxxxxxx
> >>http://www.ethereal.com/mailman/listinfo/ethereal-dev
> >>
> >>
> >>------------------------------------------------------------------------
> >>
> >>_______________________________________________
> >>Ethereal-dev mailing list
> >>Ethereal-dev@xxxxxxxxxxxx
> >>http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
--
Radek Vokál <rvokal@xxxxxxxxxx>
Attachment:
signature.asc
Description: This is a digitally signed message part