Ethereal-dev: Re: [PATCH] Re: [Ethereal-dev] Could someone with more knowledge than me update/
Jaap Keuter wrote:
Hi Ulf,
Thanks for taking the time to look at it. I'm sorry to report that your
additional changes aren't working out. Here's why.
1. You've added the option of an open interval by prefixing the record
interval by an optional dash. editcap won't grok this:
-----8<-----
jaap@host:~/capture$ editcap test.cap to10.cap -10
editcap: invalid option -- 1
....
-----8<-----
Oops, I thought it would work the same way as some other packet ranges
are done in the Ethereal code (e.g. the packet range while printing).
But now I can remember that there's a problem with a - prepended to an
option on some platforms (and iconv when I remember correct).
I've changed it back to your proposal.
2. You've added extra spaces before the example command lines. That's what
the '=over 4' tag is for. That defines the indentation the formatter uses.
If you find 4 too deep change it into 2 and let the formatter do its job.
Just to keep in style with the rest of the document I opted for 4.
Hmmm, there seems to be a difference between the manpage and HTML
formatters here.
The '=over 4' tag doesn't seem to have any effect for the HTML output,
therefore the changes. Without the spaces it's just normal floating text
which makes it hard to read.
I had a look at the other manpages, most doesn't seem to use the =over
tag but simply four spaces for such things, e.g. the filter manpage.
I've changed it that way.
Regards, ULFL
