Wireshark · Ethereal-dev: Re: [Ethereal-dev] Update to expert data

[Gilbert Ramirez <gram@xxxxxxxxxxxxxxx>]

Okay, I'll revert the patch. Sorry about committing it.

I'll look into the NCP dissector, which I mostly wrote but haven't
looked at in a long time, and find out what's happening. It does do
weird things because it's table-driven, but i wouldn't expect it to be
totally broken in regards to the rest of ethereal.

--gilbert



On 10/21/05, Guy Harris <gharris@xxxxxxxxx> wrote:
> Ulf Lamping wrote:
>
> >>> Expert data must perform a re-dissection to trigger the NCP dissector.
>
> That's a bug.
>
> >>> Change the call cf_retap_packets() to cf_redissect_packets().
>
> cf_redissect_packets() should *ONLY* be used if the expectation is that
> the actual dissection will change - i.e., that the Info column or the
> protocol tree will be generated differently as a result of some change
> made, e.g. a protocol preference change.
>
> cf_redissect_packets() causes more work to be done, so it's slower,
> *and* it causes an ugly redisplay of the packet list.
>
> > There must be a real misconception somewhere. Why it is not enough to
> > call cf_retap_packets(), maybe using code parts under if(tree)?.
>
> If that doesn't work, there's a bug somewhere in some dissector.
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
>