Ethereal-dev: Re: [Ethereal-dev] Updates to NCP dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Gilbert Ramirez <gram@xxxxxxxxxxxxxxx>
Date: Tue, 18 Oct 2005 10:07:59 -0500
Compiling packet-ncp-sss.c on Linux with gcc 4.0.2 produces these warnings:

packet-ncp-sss.c: In function 'sss_string':
packet-ncp-sss.c:494: warning: comparison between pointer and integer
packet-ncp-sss.c:554: warning: comparison between pointer and integer
packet-ncp-sss.c: In function 'dissect_sss_request':
packet-ncp-sss.c:637: warning: passing argument 6 of 'sss_string'
makes integer from pointer without a cast
packet-ncp-sss.c:640: warning: passing argument 6 of 'sss_string'
makes integer from pointer without a cast
packet-ncp-sss.c:649: warning: passing argument 6 of 'sss_string'
makes integer from pointer without a cast
packet-ncp-sss.c:654: warning: passing argument 6 of 'sss_string'
makes integer from pointer without a cast
packet-ncp-sss.c:664: warning: passing argument 6 of 'sss_string'
makes integer from pointer without a cast
packet-ncp-sss.c:667: warning: passing argument 6 of 'sss_string'
makes integer from pointer without a cast
packet-ncp-sss.c:673: warning: passing argument 6 of 'sss_string'
makes integer from pointer without a cast
packet-ncp-sss.c:676: warning: passing argument 6 of 'sss_string'
makes integer from pointer without a cast
packet-ncp-sss.c:581: warning: unused variable 'msgverb'
packet-ncp-sss.c:580: warning: unused variable 'attribute'
packet-ncp-sss.c: In function 'dissect_sss_reply':
packet-ncp-sss.c:717: warning: unused parameter 'func'
packet-ncp-sss.c: At top level:
packet-ncp-sss.c:44: warning: 'hf_sss' defined but not used
packet-ncp-sss.c:456: warning: 'align_4' defined but not used

--gilbert

On 10/18/05, Greg Morris <gmorris@xxxxxxxxxx> wrote:
>
> The following patches update the NCP dissector.
>
> makefile.common.diff - epan directory
> 1. Adds new packet-ncp-sss.c and packet-ncp-sss.h for new Secret Store
> dissector
>
> New Novell Secret Store Services dissector
> packet-ncp-sss.c
> packet-ncp-sss.h
>
> ncp2222.py.diff
> 1. Adds a number of return values
> 2. Adds 64bit file size support
> 3. Add NCP 89,xx NCP's for UTF8 support
> 4. Fixes a number of field values for proper dissection
> 5. Adds support for Secret Store dissector
>
> packet-ncp2222.inc.diff
> 1. Skwelches some compiler warnings
> 2. Redo of fix for bug 535 which original fix broke dissection of NDS verb 5
> 3. Adds support for Secret Store dissector
> 4. Adds expert data
> 5. Adds tap for service response time
> 6. Fixes dissection of stream attribute
> 7. Fixes defragmentation problem with more then 10 fragments
> 8. Fixes NDS dissection if reply buffer was less then 7
>
> packet-ncp.c.diff
> 1. Adds tap data
> 2. Adds expert data
> 3. Fixes calculation for NCP connection number
> 4. Fixes malformed packet for destroy service connection
>
> packet-ncp.c.diff
> 1. Adds tap data
>
> Please checkin, let me know if you have any questions,
> Greg
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
>
>
>