Ethereal-dev: Re: [Ethereal-dev] Re: New dissectors: H.223 and friends

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: LEGO <luis.ontanon@xxxxxxxxx>
Date: Fri, 7 Oct 2005 22:45:31 +0200
checked in (r16155)

On 10/7/05, Richard van der Hoff <richardv@xxxxxxxxxxxxx> wrote:
> Guy Harris wrote:
> > Richard van der Hoff wrote:
> >
> >> yup, that seems fine. Sorry again for overlooking these - it's quite
> >> hard to spot them with a compiler that doesn't complain :(.
> >
> >
> > There's an assertion violation - it was causing a crash when the
> > assertion was done with g_assert(), but dissectors should use
> > DISSECTOR_ASSERT() so that, while dissection of the packet that provokes
> > the dissector bug is aborted, procesing the capture file isn't.  I've
> > checked in a change to make it do so.
> >
> > See bug 508:
> >
> >     http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=508
> >
> > which has a capture file that provokes the problem attached.
>
> Indeed. Sorry about that - try this patch. Looks like that will fix bugs
> 509 and 510 too.
>
> Richard
>
>
> --
> Richard van der Hoff <richardv@xxxxxxxxxxxxx>
> Systems Analyst
> Tel: +44 (0) 845 666 7778
> http://www.mxtelecom.com
>
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>
>
>
>


--
This information is top security. When you have read it, destroy yourself.
-- Marshall McLuhan