Ethereal-dev: Re: [Ethereal-dev] Bug fix in packet-iax2.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Mon, 03 Oct 2005 17:53:19 +0200
checked in.

BTW: had to do this by hand (subversion failed to patch), are you using svn or some different diff tool?

Regards, ULFL

Peter Johansson wrote:

The supplied patch resolves an issue with the use of the not yet initialized variable "fid".

/ Regards, Peter

------------------------------------------------------------------------

Index: C:/ethereal-win32-libs/epan/dissectors/packet-iax2.c
===================================================================
--- C:/ethereal-win32-libs/epan/dissectors/packet-iax2.c	(revision 16077)
+++ C:/ethereal-win32-libs/epan/dissectors/packet-iax2.c	(working copy)
@@ -1721,9 +1721,9 @@
    /* then we are continuing an already-started pdu */
    frag_len                     = tvb_reported_length( tvb );
    offset                       = 0;
-    tot_len                      = GPOINTER_TO_UINT(g_hash_table_lookup(iax_call->totlen_table, GUINT_TO_POINTER(fid)));
    if(!pinfo->fd->flags.visited) {
      fid = dirdata->current_frag_id;
+      tot_len                      = GPOINTER_TO_UINT(g_hash_table_lookup(iax_call->totlen_table, GUINT_TO_POINTER(fid)));
      g_hash_table_insert( iax_call->fid_table, GUINT_TO_POINTER(pinfo->fd->num), GUINT_TO_POINTER(fid) );
      frag_offset                  = dirdata->current_frag_bytes;
      complete                     = dirdata->current_frag_bytes > tot_len;
------------------------------------------------------------------------

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev