Ethereal-dev: Re: [Ethereal-dev] Optimization: remove the unconditional ip_checksum() in packe

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Kaul <mykaul@xxxxxxxxx>
Date: Mon, 26 Sep 2005 00:17:01 +0300
I actually don't think it should be checked in, a week prior to releasing a new version (that's the plan, no?), for the sake of stability.

By extensive testing, I mean I'd be greatful if others, who might have more capture samples can run with this to make sure I didn't break anything.

I would be happy to see http://www.ethereal.com/lists/ethereal-dev/200509/msg00179.html checked in, though.  It's useful (for me, at least) and not at all risky.

Y.


On 9/25/05, Ulf Lamping <ulf.lamping@xxxxxx> wrote:
Kaul wrote:

> Attached patch.
> Comments are welcome + extensive testing, please.

Sorry, don't have the time now to look at your patch (currently looking
at #322 and having a hard time to fix it), anyone else?

BTW: What do you mean by: "extensive testing, please"? You should do
extensive testing yourself before submitting any patches...

Regards, ULFL