Ethereal-dev: Re: [Ethereal-dev] Problem with call_dissector()?

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
Date: Mon, 26 Sep 2005 05:45:22 +1000
Yes   Im pretty sure you have to check it for NULL before you use it.

I think it was changed some time ago to better allow for ethereal to find which dissector to use if for example
you had a conversation vs heuristic dissector conflict.


Can you specify where in the docs it is mentioned you dont have to check for NULL?


On 9/26/05, Mike Duigou <ethereal@xxxxxxxxxx> wrote:
I've been using the following snippet in my dissector for a while:

mime_dissector_handle = dissector_get_string_handle(
     media_type_dissector_table, content_type);

dissected = 0 < call_dissector(
     mime_dissector_handle, jxta_message_tvb, pinfo, tree);

but with recent builds it's segfaulting in call_dissector_work when
there is no registered dissector matching the mime type in content_type.
(NULL is passed to call_dissector() )

I'm a bit confused as to how this should work. Should I be checking the
result of dissector_get_string_handle() for NULL? The docs seem to imply
that I should be able to use call_dissector() with a NULL dissector
handle and just get the raw data dissector.

Mike

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev