Ethereal-dev: [Ethereal-dev] Re: rev 15995: /trunk/epan/dissectors/: packet-fcp.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
Date: Sat, 24 Sep 2005 21:46:36 -0400
There are still just over 200 strcpy() left in the dissectors,

150 of them are in fibre channel related dissectors  and most of them
need to be refactored in the same way as this checkin did.

(most of them are "safe" and little/no risk for stack corruption  but
it is better to get rid of all of them anyway   and as a bonus the
dissection becomes much much better for bitfields anyway.)


On 9/24/05, sahlberg@xxxxxxxxxxxx <sahlberg@xxxxxxxxxxxx> wrote:
> User: sahlberg
> Date: 2005/09/24 06:25 PM
>
> Log:
>  prettify the previous patch
>
>  remove the remaining strcpy() from this dissector and make it decode the
> bitmap PROPERLY.
>
> Directory: /trunk/epan/dissectors/
>   Changes    Path            Action
>   +113 -48   packet-fcp.c    Modified
>
>
>
> http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=15995&view=rev
>
> _______________________________________________
> Ethereal-cvs mailing list
> Ethereal-cvs@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-cvs
>