I had a few questions about the dissector:
Why does the dissector have its own MAC_to_str() function? Wouldn't
ether_to_str() or get_ether_name() work?
The code beginning at line 619 seems odd:
strcpy(tempStr,MAC_to_str(mac_addr, 6, ':'));
proto_tree_add_text(chassis_tree, tvb, (offset+3), 6,
"Chassis Id: %s", tempStr);
proto_tree_add_ether_hidden(chassis_tree, hf_chassis_id_mac,
tvb, (offset+3), 6, mac_addr);
Couldn't this just be
proto_tree_add_ether(chassis_tree, hf_chassis_id_mac, tvb,
(offset+3), 6, mac_addr);
The code uses strcpy() a LOT. Can these be removed?
In dissect_media_tlv(), shouldn't LCI_Length be unsigned in order to
avoid excessive looping?
Anders Broman wrote:
> Hi,
> Checked in as a normal dissector as suggested by Jim Young with removal of
> c++ style comments, non of the warnings mentioned are seen by MSVC6.
>
> Brg
> Anders
>
> -----Ursprungligt meddelande-----
> Från: ethereal-dev-bounces@xxxxxxxxxxxx
> [mailto:ethereal-dev-bounces@xxxxxxxxxxxx] För Brian Bogora
> Skickat: den 13 september 2005 14:57
> Till: Ethereal
> Ämne: [Ethereal-dev] LLDP Plug-in Submission
>
> Hi All,
>
> Our company (Mitel) has developed an LLDP-MED plug-in for Ethereal. I
> have attached the source code for comments, suggestions and submission.
>
> Thanks,
>
> Brian Bogora
> Mitel Networks
> Brian_Bogora@xxxxxxxxx
> (613)592-5660 X4999
>
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
