Ethereal-dev: Re: [Ethereal-dev] netxray.c patches

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Tue, 30 Aug 2005 03:38:50 -0700
Bill Meier wrote:

Comments::

[I should have better explained my reasons for certain parts of the patch]

Re: "Get rid of the old file header definition." (in the SVN 15606 note)
I left the old header in under '#ifdef 0' so the references to 'xxb' and 'xxc' in several comments would continue to make sense. I can submit a patch changing the (small number of) comments with these references.
That would make sense - the new header definition is the better one, so the comments should refer to it.
I have a change to base the usec/nsec decision on the time units value (if it's > 10^6, use nsec).
I made the change to display nanosecs only for the gigpod because, of the captures I have, only the gigpod captures display in the snffer 
  with nanosecs precision for time.
It seems to me that displaying nanosecs for the Tps=1193000, 1193182, and 1250000 cases suggests too high an accuracy.
...hence my XXX comment. An alternative might be "if (timeunit >= 1e7)", for example.