Ethereal-dev: [Ethereal-dev] Re: Patch to packet-dec-dnart.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
Date: Wed, 24 Aug 2005 03:39:56 -0400
The patch does not apply to SVN,

can you regenerate it and resend it.


Looking at the dissector,   could you also remove that
APPEND_BOOLEAN_FLAG thing and replace it with proper
proto_tree_add_item()   and hf_fields of type FT_BOOLEAN

It would make the dissector much better.



On 8/21/05, Martin Hill <martin_j_hill@xxxxxxxxxxx> wrote:
> An extremely useful addition, unfortunately it has a bug that prevents it 
> from correctly decoding messages containing no padding. I also added display
> 
> of DECnet addresses in area.node format. Attached is a diff from the latest
> 
> trunk.
> 
> rgds
> Martin Hill
> 
> 
>