Ethereal-dev: Re: [Ethereal-dev] RFC: add more flags to the protocol tree for a start of an ex
Joerg Mayer wrote:
On Sun, Aug 21, 2005 at 05:40:24PM +0200, Ulf Lamping wrote:
The protocol item in the protocol tree will have a gray background now,
which makes it much better visible.
Add some more optional flags to the protocol items, so more "special
cases" can be marked in the protocol tree. What came to my mind:
/** The protocol field has a bad checksum */
FI_CHECKSUM_ERROR
/** The protocol field has an unusual sequence (e.g. TCP window is zero) */
FI_SEQUENCE_WARNING
/** The protocol field has a bad sequence (e.g. TCP segment is lost) */
FI_SEQUENCE_ERROR
I think that this approach is a bit inflexible as we need global flags for
protocol specific intelligence.
How about a two-part value (like syslog):
1) a (global) severity (e.g. info, warn, error, security)
Yes, that's the 2-3 bits I've mentioned before.
2) a (protocol specific) meaning (e.g. tcp: window, wrong seqno, etc)
That would make it hard to find a general way to display it. However,
the severity might be enough to manipulate the display in the proto_tree.
The severity can then be used to filter (and apply colours) packets,
I don't know if it's possible to filter on that items. It's a good idea
to be able to do that anyway.
the protocol specific meaning can be used to display what is going on.
I would think that we have already enough ways to display things in a
textual form.
My idea is a way to "manipulate" how the fields are displayed in the
proto_tree.
I could think about many other improvements like a new column with the
"warning level" displayed, but let's do one step at a time ...
I think we might first try to find all the places and causes so we can
have a better understanding what and how it should be displayed /
filtered ...
Regards, ULFL
