Ethereal-dev: [Ethereal-dev] Re: [Ethereal-cvs] rev 15493: /trunk/epan/dissectors/: packet-ans

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Sun, 21 Aug 2005 12:11:51 +0200
guy@xxxxxxxxxxxx wrote:


User: guy
Date: 2005/08/21 04:48 AM

Log:
Add a "register_dfilter_stat()", to register stats that take a display
filter as an argument on the command line and have a dialog box to enter
the display filter through the GUI.  Use it for all stats using
"gtk_tap_dfilter_dlg_cb()".
I think it's a *very bad idea* to use the gtk_ prefix for our own code. This prefix should *only* be used by the GTK functions/files.
This way, you can see which part belongs to our stuff and which is coming from the GTK libs.
Please change it, maybe to gui_ as I've done for the gui_utils.h file yesterday.
If we committing us to a different name I would have no problem to change this too. 



Add a top-level "stat_menu.h" file to declare "REGISTER_STAT_GROUP_E"
for the benefit of the declaration of "register_dfilter_stat()" in the
top-level "tap_dfilter_dlg.h".  Rename the "stat_menu.h" in the gtk
directory to "gtk_stat_menu.h", so as not to have two headers with the
same name.


Same as above.

Regards, ULFL