Ethereal-dev: Re: [Ethereal-dev] ememification of tvb_get_tring() and friends

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
Date: Wed, 3 Aug 2005 08:35:37 +1000
On 8/3/05, Ulf Lamping <ulf.lamping@xxxxxx> wrote:
> Maynard, Chris wrote:
> 
> >Since the "ephemeral" names are transitional only, I don't think it
> >matters too much, since eventually they will be renamed back to their
> >originals without the "ephemeral" designation anyway.  Or has that idea
> >changed?
> >
> >
> As far as I understood Ronnie, this will be the permanent names in the
> "future".

Yes that was my original idea, to  make tvb_get_string() always return
"ephemeral" data and those very very few users (packet-sdp.c) that
need a string with a longer lifetime doing an explicit  strdup or
something.

But I thought from earlier comments it would be preferred with
essentially three copies of all functions such as
tvb_get_ephemeral_string()
tvb_get_seasonal_string()
and maybe
tvb_get_gmalloced_string()    (which has to be explicitely freed())

If the consensus isntead is to have only one function
tvb_get_string()  that is changed from returning gmalloced() data to
be ephemeral data   im ok with that path as well.


The temporary names are now ep_...
I wanted to check whether to rename them back to tvb_get_string() or
to tvb_get_ephemeral_string()   or something else.