Wireshark · Ethereal-dev: [Ethereal-dev] Re: [Ethereal-cvs] rev 14895: /trunk/gtk/: tcp_graph.c

[ronnie sahlberg <ronniesahlberg@xxxxxxxxx>]

On 7/11/05, guy@xxxxxxxxxxxx <guy@xxxxxxxxxxxx> wrote:
> User: guy
> Date: 2005/07/10 01:29 PM
> 
> Log:
>  Just pass &cfile to select_tcpip_session(); we don't need to pass
>  cfile.current_frame to it separately.
> 
>  Note that we shouldn't ever get a "Selected packet isn't a TCP segment"
>  error any more; we can now handle all link layers.

Well, there exists packets not containing any tcp headers at all.
:-)

But we should not get this error any more for packets that are tcp.


Anyone that wants to do a performance test on a huge capture, please
do so so we can see how big the performance impact is by going to a
tap solution.


> 
>  Give a little more detail in the message shown if there's *more than
>  one* TCP header in the packet.
> 
> Directory: /trunk/gtk/
>   Changes    Path           Action
>   +16 -17    tcp_graph.c    Modified
> 
> 
> 
> http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=14895&view=rev
> 
> _______________________________________________
> Ethereal-cvs mailing list
> Ethereal-cvs@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-cvs
>