Ethereal-dev: [Ethereal-dev] Re: About bug 188

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
Date: Fri, 27 May 2005 02:03:39 -0400
I have checked in a fix. it should work now.
Thanks for the bugreport.

The problem is that proto_item_append_string() does not play well with
the TRY_TO_FAKE_THIS_ITEM() optimization.
Fortunately proto_item_append_string() is very rare,   essentially
only called from WSP.

I have added a comment to proto_item_append_string() and how it
interacts (or fails to interact) with TRY_TO_FAKE_THIS_ITEM() and what
one needs to do if one uses this function.

I have added a change to WSP so that it will unconditionally disable
the optimization for WSP and all subdissectors of WSP.


On 5/26/05, didier <dgautheron@xxxxxxxx> wrote:
> Hi,
> bug 188 *is* related to the speed optimization, it tries to add a string 
> to the protocol field :(
> 
> Didier
> 
> 
>