Ethereal-dev: Re: [Ethereal-dev] [patch] voip_calls.c lost isup calls with same CIC but differ

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Gerald Combs <gerald@xxxxxxxxxxxx>
Date: Mon, 02 May 2005 09:45:52 -0500
Checked in.

Cvetan Ivanov wrote:
> Hi,
> 
> This patch fixes the slightly broken logic in the loop which searches
> for establisted call in isup_calls_packet.
> 
> The problem is that (right_pair) is set to false if we see call on the
> same CIC as existing conversation, but with different opc/dpc pair:
> 
> at this point dpc/opc pair is not checked, so any call with the same CIC
> matches:
> 
> voip_call.c:851
>                                  else{
>                                          right_pair = FALSE;
>                                  }
> 
> and then the correct conversation is never found, because right_pair is
> never reset for this packet, which leads to total confusion of the call
> tracking logic
> 
> Fixed by initializing right_pair = TRUE for every loop iteration
> 
> 
> 
> Best regards,
> 
> Cvetan
> 
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev