Wireshark · Ethereal-dev: [Ethereal-dev] [patch] packet-isup.c empty calling station id fixes

[Cvetan Ivanov <zezo@xxxxxxxxx>]

Hi,

thist patch fixes two things

1) dissect_isup_calling_party_number_parameter reported malformed packet 
if the calling party number IE contains empty number (possibly with 
presentation set to 'number not available')

I've basicly added if(length > 0) around the digits tree dissector, 
which may not be obvious from the patch becase of the indenting of the 
entire block.

2) As the tap_calling_number is static, if there is call with missing 
calling_party_number IE, it gets assigned the calling party number of 
the previuos call containing such IE.

fixed by adding tap_calling_number = NULL; in the beginning of 
dissect_isup_message, and
tap_rec.calling_number=tap_calling_number?tap_calling_number:g_strdup("");

in the end to avoid segfault

Those things may not happen too often in the telecom world, but happen 
all the time with VoIP.


best regards,

Cvetan

Attachment: isup_calling.patch.gz
Description: application/gzip