Ethereal-dev: Re: [Ethereal-dev] Bug 72 (huge fragmentation offset)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Peter Johansson <Peter.xc.Johansson@xxxxxxxxxxxx>
Date: Thu, 21 Apr 2005 07:49:10 +0200
Dinesh G Dutt wrote:


I don't think this is a problem with reassemble.c. The frame in question
was a bogus fragment. No attempt should have been made to reassemble it.

Dinesh
I tend to disagree when it comes to blaming reassemble.c. You are right when you identified that this is in fact a problem in packet-fc. The problem however, which also is discussed in http://www.ethereal.com/lists/ethereal-dev/200504/msg00300.html (partially in Swedish, the vital parts in English though), is that a flaw in any dissector may cause a crash in reassemble.c. I fear that one could create malicious data streams for a vast number of protocols which would again cause crashes in reassemble.c. Should we perhaps consider making changes to reassemble.c that makes it impervious to dissector flaws? 

/ Peter