The attached patch fixes a few bugs in packet-pktc.c (PacketCable
Kerberized Key Management in particular):
- list of ciphersuites now correctly summarizes the encryption
algorithms with their descriptive names
- Security Parameter Index (SPI) for IPsec changed to BASE_HEX to align
with packet-ipsec.c
Works for me. Please review and apply.
+Thomas
--
Thomas Anders (thomas.anders at blue-cable.de)
--- epan/dissectors/packet-pktc.c.rev11410 2005-03-10 16:53:39.000000000 +0100
+++ epan/dissectors/packet-pktc.c 2005-04-15 00:09:17.570816128 +0200
@@ -277,6 +277,7 @@
/* SNMPv3 encryption transform id */
proto_tree_add_item(tree, hf_pktc_snmpEncryptionTransformID, tvb, offset, 1, FALSE);
+ proto_item_append_text(tree, "/%s", val_to_str(tvb_get_guint8(tvb, offset), snmp_transform_id_vals, "%0x"));
offset+=1;
}
break;
@@ -289,7 +290,7 @@
/* IPsec encryption transform id */
proto_tree_add_item(tree, hf_pktc_ipsecEncryptionTransformID, tvb, offset, 1, FALSE);
- proto_item_append_text(tree, "/%s", val_to_str(tvb_get_guint8(tvb, offset), snmp_transform_id_vals, "%0x"));
+ proto_item_append_text(tree, "/%s", val_to_str(tvb_get_guint8(tvb, offset), ipsec_transform_id_vals, "%0x"));
offset+=1;
}
break;
@@ -696,7 +697,7 @@
"SNMPv3 USM User Name", "pktc.asd.snmp_usm_username", FT_STRING, BASE_DEC,
NULL, 0, "SNMPv3 USM User Name", HFILL }},
{ &hf_pktc_ipsec_spi, {
- "IPsec Security Parameter Index", "pktc.asd.ipsec_spi", FT_UINT32, BASE_DEC,
+ "IPsec Security Parameter Index", "pktc.asd.ipsec_spi", FT_UINT32, BASE_HEX,
NULL, 0, "Security Parameter Index for inbound Security Association (IPsec)", HFILL }},
{ &hf_pktc_reestablish_flag, {
"Re-establish Flag", "pktc.reestablish", FT_BOOLEAN, BASE_NONE,
