Wireshark · Ethereal-dev: Re: [Ethereal-dev] Re: MGCP update

["Martin Mathieson" <martin.mathieson@xxxxxxxxxxxx>]

I must admit, editing that file made me feel dirty.

I tidied up those parts that I had to understand/change, but didn't want to
send a large patch that had lots of functional *and* refactoring changes
(making it more difficult to review the functional changes).  I expect I'll
have more updates over the next few weeks, I'll make the next one I send
cleanup-only.  I suspect that after tidying up a few parts, fixing the
formatting, and adding some comments, the structure of this file is actually
OK.

I can't think of any reason for mgcp to be a plugin.  In fact, other than to
help maintain the plugin api I'm not sure why any of the dissectors in svn
are plugins.

Regards,
Martin

> (the plugin dissectors are living in unmaintained land as far as i see
> it,  but boy is the mgcp dissector ugly?    would be very nice to
> refactor it to look nice and later convert it to become a normal
> dissector)
>