On Thursday 24 March 2005 10:10, Ulf Lamping wrote:
> Thomas Boehne wrote:
> >I think the correct solution is:
> >
> >Let the user check/uncheck any checkbox, and show an error message if
> >OK is clicked when "Use multiple files" is checked, and neither of the
> >two "next file every" options is checked.
>
> The way you describe it would make sense.
>
> But the current implementation uses the default enabling of the file
> size as a mechanism to provide a meaningful default set. This mechanism
> is used every time some setting had changed in the box.
> The other possible way would leave both checkboxes unchecked, which
> would mean having the default for multiple files always resulting in the
> error message you've noticed above, which is even more undesirable IMHO.
I just found out that the error message that I described is already in
capture_dlg.c (although there seems to be no way to open it):
... if (!capture_opts->has_autostop_filesize && !capture_opts->has_file_duration) {
simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK,
PRIMARY_TEXT_START "Multiple files: No file limit given!\n\n" PRIMARY_TEXT_END
"You must specify a file size or duration at which is switched to the next capture file\n"
"if you want to use multiple files.");
Why don't we just start with the default settings
(has_autostop_filesize) and show this error message in case the user
unchecks has_autostop_filesize without checking has_file_duration?
I was looking at the struct capture_options_tag and am a little
confused now: Are we misusing autostop_filesize to specify the size of
each single file in case multiple files are used? If that's true, it
should probably be documented.
Sincerely yours,
Thomas Böhne
--
Jäger Computergesteuerte Messtechnik GmbH
Thomas Böhne
Rheinstraße 2-4
64653 Lorsch
Germany
Phone: +49-6251-9632-0
