Wireshark · Ethereal-dev: Re: [Ethereal-dev] IKEv2 support

[Shoichi Sakane <sakane@xxxxxxxx>]

Hi,

I resubmit the patch for the 0.10.10 to support parsing IKEv2 packets
as Ronnie's comment.  I hope it will be merged to the next release.


Regards,

> Try to convert all of those that makes sense to convert.
> 
> On Fri, 04 Mar 2005 10:27:39 +0900, Shoichi Sakane <sakane@xxxxxxxx> wrote:
> > Thank you for helpful comment.
> > 
> > > A lot of the lists for strings in this dissector use locally defined structs
> > > such as static struct type2str_t v2_idtypestr[] = {
> > > and locally defined macros to search them.
> > >
> > > It would be much better if these lists of strings were changed into a
> > > struct value_string  since htere are standard methods (val_to_str) in ethereal
> > > to parse this kind of very common datastructure.
> > 
> > > can you consider refactoring all the lists of strings into being value_string ?
> > 
> > Sure, I will try to change them.  There are alike mechanism such like
> > char *p1_atttypestr[NUM_P1_ATT_TYPES] = { and macros to convert them
> > in the original source code.  Should I improve them to the method what
> > you suggested ?
> > 
> >
> 
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev
>