Ethereal-dev: Re: [Ethereal-dev] Re: packet-pgsql.c changes in 0.10.9

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Mon, 07 Mar 2005 23:57:11 -0800
Abhijit Menon-Sen wrote:


In case this caused any confusion, the problem was that code like this:

    gint l = tvb_get_ntohl( ... );
When was there ever code like that? There was never any code, at least in any version checked into SVN, that assigned the length in question to a signed integer, which was the real problem - given that it has always been unsigned, "l > 0" just means "l != 0", which means that it was treating a negative length, such as -1, as a large positive length.