Ethereal-dev: Re: [Ethereal-dev] test randpkt crashes on FreeBSD buildbot

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Sun, 06 Mar 2005 12:40:43 -0800
LEGO wrote:

the last change to packet-bacapp.c probably got something broken.

I tried to find it myself with no luck (I cannot get tethereal to
crash on my machine).
You might have to keep trying - or convince your compiler not to do tail-recursion elimination. (I'm a bit surprised, as I've seen the OS X gcc do tail-recursion elimination, but perhaps it had a higher optimization level when it'd done that.) 


could we export the file that causes the crash from the buildbot so
that crashes can be analyzed?
That'd be useful - but just iterating a randpkt/tethereal pair found at least one problem, namely that, as it's dissecting some SEQUENCE and SEQUENCE OF items by recursion, it depends on the compiler doing tail-recursion elimination; otherwise, you run the risk of running out of stack space. 

That might be the problem.  I'll look at getting rid of the recursion.