Ethereal-dev: Re: [Ethereal-dev] Voip Calls analysis and Graph analysis

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Lars Roland <lars.roland@xxxxxxx>
Date: Sun, 20 Feb 2005 17:00:01 +0100
Lars Roland schrieb:
Having a short look at the patch, I have to disagree on an implementation detail:
I don't like to have the mgcp dissector allocating a mgcp_info_t structure for each dissection of an mgcp packet without freeing it. This could be considered to be a big memory leak. Instead use a static array of mgcp_info_t structures. You can take the h225 or the q931 dissector as an example of such an implementation. 



On Fri, 18 Feb 2005 13:00:00 -0700, Alejandro Vaquero
<alejandrovaquero@xxxxxxxxx> wrote:


Hi All,
   find attached a patch to add MGCP calls to the "Voip Analysis". The
implementation is oriented to MGCP Residential Gateways.
checked in along with the changes I've proposed above and an additional check for the presence of the mgcp plugin. 

Regards,
Lars