Ethereal-dev: Re: [Ethereal-dev] [patch] conversations demarked by setup frame number
Being relatively new to this list, I'm not sure how to interpret the lack of
response to this patch (except for one person indicating support for it's
inclusion). Either: a) Nobody cares, b) The message was not seen for some
reason. (The thread is entirely in the archives). c) The patch is
unacceptable. d) I've offended someone (I certainly hope not, and appologize
if I have :)
If there is something wrong with the patch, or the direction that I was taking
with the solution, please let me know. I'd be happy to pursue an alternate
solution if one is suggested.
Thank you,
Jon
On Saturday 22 January 2005 09:41 pm, Jon Ringle wrote:
> On Tuesday 18 January 2005 10:27 am, Jon Ringle wrote:
> > On Tuesday 18 January 2005 02:01 am, Jon Ringle wrote:
> > > 1) Added a setup_frame parameter to conversation_t
> > > 2) Used the conversation_t next to maintain a list of conversations
> > > with the same src/dest tuple but different setup_frame number.
> > > 3) Changed the signature of find_conversation() and conversation_new()
> > > to pass in the frame number.
> > > 4) Adjusted packet-sdp to select RTP conversation if both m=audio and
> > > m=image are present, and T.38 conversation if only m=image is present.
> > > I expect that RTP/T.38 dissecting to be better, but I don't have a way
> > > to generate T.38 packets.
> >
> > One additional comment I'd like to make is that I don't believe that the
> > functional behaviour has changed for any protocol with this patch except
> > for SDP setting up multiple RTP/T.38 conversations based on the
> > setup_frame number. The reason is that find_conversation() will return a
> > conversation if one exists for the src/dest tuple. All the dissectors
> > that use find_conversation() before invoking conversation_new() only test
> > for a preexisting conversation. A dissector needs to add additional logic
> > after the call to find_conversation() to decide whether
> > conversation_new() needs to be called anyway even if there is a
> > preexisting conversation. For instance in add_rtp_conversation() there is
> > a test to see if the setup_frame_number matches the setup_frame number
> > returned from
> > find_conversation():
>
> Now that 0.10.9 is released, I was wondering if the patch at:
> http://www.ethereal.com/lists/ethereal-dev/200501/msg00408.html
> could be applied, if it looks ok.
>
> Attached is an abbreviated version of this patch that has the functional
> changes for review. The full patch in my previous location is mostly adding
> the extra parameter to all the calls to find_conversation() and
> conversation_new().
>
> Jon
